refactor: call CPU backend functions dynamically#1591
Open
wbruna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
ggml_backend_cpu_init,ggml_backend_is_cpu,ggml_backend_cpu_set_n_threadsfunctions with dynamic ggml backend calls, and avoidsggml_cpu_has_*by getting the flags with a function provided by ggml.These functions are not available without native CPU builds. With these changes, I was able to build and run sd.cpp with a runtime-selected CPU backend (
-DSD_BUILD_SHARED_LIBS=ON -DSD_BUILD_SHARED_GGML_LIB=ON -DGGML_BACKEND_DL=ON -DGGML_CPU_ALL_VARIANTS=ON).It changes the CPU info log, since ggml only reports the active flags, but I've tried to keep the formatting similar:
Related Issue / Discussion
Should fix #1567, although the issue with
GGML_MAX_NAMEwould remain.Could help with #1589, #1588, #1483, #1351 by allowing binary releases using dynamically-selected ggml CPU backends.
Complements the runtime backend selection (#1448).
Checklist