[Docs] fix(ui): resolve TOC scrollbar overlap and top clipping - #1203
[Docs] fix(ui): resolve TOC scrollbar overlap and top clipping #1203akshatsinghai6682-sketch wants to merge 7 commits into
Conversation
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe project stylesheet updates scrollbar spacing and WebKit scrollbar styling for both sidebars. The TOC sidebar applies scrolling rules without an ChangesSidebar styling
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR makes a localized documentation UI styling change to improve sidebar scrollbar spacing and clipping behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1203/
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/scss/_styles_project.scss`:
- Around line 314-315: Remove the blank line immediately before the position
declaration in the affected style rule, keeping padding-right and position as
consecutive declarations.
- Around line 325-341: Extend the scrollbar styling beside the existing
`.td-sidebar-toc` rules to also target `.td-sidebar`, including scrollbar width,
transparent track with the same top and bottom margins, primary thumb color,
rounded corners, and hover color. Keep TOC-specific `scrollbar-gutter` and
`margin-right` declarations scoped only to `.td-sidebar-toc`.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 76f5a754-cd7b-4f55-a912-028f70a85414
📒 Files selected for processing (1)
assets/scss/_styles_project.scss
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
dhruveshmishra
left a comment
There was a problem hiding this comment.
In line number 317 are both padding-right: calc(sidebar-padding-horizontal} + 8px); and margin-right: 8px; necessary here? Using both may add extra empty space or shift the TOC more than intended.
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
"Thanks @dhruveshmishra! The padding-right uses the default $sidebar-padding-horizontal without any extra offset alongside margin-right: 8px to prevent redundant spacing." |
PARTH-TUSSLE
left a comment
There was a problem hiding this comment.
Hey @akshatsinghai6682-sketch ,Thanks for the update , the overall approach looks good and the before/after screenshots make the fix much easier to verify. Before merging, could you please keep the diff limited to the scrollbar/top-clipping fix and remove the unrelated formatting/comment cleanup? Also, please verify that both the existing padding-right and the new margin-right: 8px are necessary and that the fix behaves correctly in Firefox as well as Chromium. Once that's confirmed, LGTM.
|
Sure @PARTH-TUSSLE |
Removed commented fix for scrollbar overlap and adjusted styles. Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
|
Hey @PARTH-TUSSLE, thanks for the detailed review!
Let me know if any more changes are required Thank You |
PARTH-TUSSLE
left a comment
There was a problem hiding this comment.
Thanks for addressing the review points and cleaning up the diff. The change is now appropriately scoped to the issue. LGTM 🦖
Maanvi212006
left a comment
There was a problem hiding this comment.
LGTM! The fix correctly addresses the scrollbar overlap by reserving scrollbar space and adding separation from the browser scrollbar. The project builds successfully as well.
Notes for Reviewers
This PR fixes #1172
scrollbar-gutter: stable;and a8pxright margin to.td-sidebar-tocto prevent its custom scrollbar from overlapping the browser's native scrollbar.margin-top: 0.5rem; margin-bottom: 0.5rem;) to both.td-sidebarand.td-sidebar-tocscrollbars so their top corners/tips are not clipped under the sticky header.6pxwidth, cyan$primarythumb color, and rounded corners across both left and right sidebars.Screenshots
Before:


After:
Signed commits
Summary by CodeRabbit