feat: Add async DynamoDB persistent feature store - #490
Draft
jsonbailey wants to merge 1 commit into
Draft
Conversation
Builds on the async persistence foundation (AsyncFeatureStoreCore + AsyncCachingStoreWrapper). Adds the async-dynamodb extra pulling aioboto3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds an async DynamoDB persistent feature store:
AsyncDynamoDBFeatureStore,constructed via
DynamoDB.async_feature_store(...). It builds directly on the asyncpersistence foundation merged in #488 (
AsyncFeatureStoreCore+AsyncCachingStoreWrapper),providing the DynamoDB-backed core.
The store uses the same table layout and key schema as the synchronous DynamoDB feature
store, so an async SDK and a synchronous SDK can share a single DynamoDB table.
New optional dependency
Adds an
async-dynamodbextra that pulls inaioboto3.boto3is sync-only, so asyncaccess needs
aioboto3(which runs onaiobotocore). The existing syncdynamodbextra(boto3) is unchanged.
Client lifecycle
aioboto3clients are async context managers and cannot be created in__init__the waythe sync boto3 client is. The client is therefore created lazily on first use, bound to the
running event loop, kept for the lifetime of the store, and released in
close().Testing
Unit tests that do not need a backend (the caching-wrapper wiring and the missing-
aioboto3guard) run in the normal suite. The integration tests require a live DynamoDB Local instance,
so they run in CI rather than locally.
Notes
feat: Add async DynamoDB persistent feature store