ci: Use the latest v3 contract test harness - #431
Draft
kinyoklion wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Companion to the same pin move in ruby-server-sdk (launchdarkly/ruby-server-sdk#414).
Describe the solution you've provided
The v3 contract test job was pinned to
v3.0.0-alpha.6, so new coverage added to the harness never reaches CI. Moved the pin to floatingv3.Validated locally before bumping:
testservicebuilt from this branch, run against the released harnessv3.2.0-alpha.6— 4946 total, 12 skipped, all ran passed (persistence tests skipped locally; CI runs them withenable_persistence_tests).Describe alternatives you've considered
Pinning to
v3.2.0-alpha.6— a floatingv3keeps the SDK honest against new coverage as it lands, which was the intent of the pin move.Additional context
For contrast, python-server-sdk fails 6 subtests against the released harness (attribute-reference escaping in
_meta.redactedAttributes), so its pin was left alone. ruby-server-sdk failed the same 6 and is being fixed in launchdarkly/ruby-server-sdk#415.Link to Devin session: https://app.devin.ai/sessions/316afaccd2604f8d802a72c9080f6921
Requested by: @kinyoklion