Skip to content

chore: harden the skip-value allocation test against unrelated allocations #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 2 commits into from
Aug 13, 2026
+7 −1
Merged

chore: harden the skip-value allocation test against unrelated allocations #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e2e4c7
chore: make the skip-value allocation test tolerant of unrelated allo…
kinyoklion Aug 13, 2026
121ae6c
Merge branch 'v3' into rlamb/reader-allocs-test-hardening-v3
kinyoklion Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jreader/reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,13 @@ func TestReaderSkipValueAllocations(t *testing.T) {

data := []byte(`{"a":1, "b":{"b1":"two", "b2":"three"}, "c":4}`)

allocs := testing.AllocsPerRun(1, func() {
// AllocsPerRun reads an allocation counter that applies to the whole process. An
// unrelated allocation on another goroutine, for example a timer or a finalizer, can
// increase the result of a single run. The average of 100 runs removes these errors,
// because AllocsPerRun divides the total allocation count by the run count and
// truncates the result. An allocation in the code under test occurs in each run, so
// the result stays 1 or more.
allocs := testing.AllocsPerRun(100, func() {
r := NewReader(data)
obj := r.Object()
require.NoError(t, r.Error())
Expand Down
Loading