feat: Add FDv2 payload handling to the data source event handler#305
Draft
kinyoklion wants to merge 1 commit into
Draft
feat: Add FDv2 payload handling to the data source event handler#305kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
DataSourceEventHandler.handlePayload: the entry point the FDv2 data pipeline (a later PR) calls when a payload completes. Nothing produces payloads for the event handler yet, so behavior is unchanged.The method maps the payload's updates to item descriptors with the flag-eval mapper, applies them through
FlagManager.applyChanges(full replaces, partial applies, none takes no action), and marks the data source valid — a payload of any type, including none, confirms the connection is delivering current data. Unparseable flag data is classified as aninvalidDataerror and reported through the status manager, mirroring how the FDv1 message verbs handle bad payloads; the in-progress payload is discarded.Testing
New tests cover all three transfer types end to end through the event handler (full replaces the stored flags and applies the environment ID, partial applies updates without per-item version comparison, none changes no data), the valid status transition, and invalid flag data producing an
invalidDataerror withMessageStatus.invalidMessage.SDK-2186