Skip to content

chore: Declare the hook-environment-id contract test capability - #330

Merged
kinyoklion merged 3 commits into
mainfrom
devin/1786558601-hook-environment-id-capability
Aug 13, 2026
Merged

chore: Declare the hook-environment-id contract test capability#330
kinyoklion merged 3 commits into
mainfrom
devin/1786558601-hook-environment-id-capability

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 12, 2026

Copy link
Copy Markdown
Member

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Depends on launchdarkly/sdk-test-harness#410, which adds the hook-environment-id capability and a test asserting evaluationSeriesContext.environmentId.

Describe the solution you've provided

Only the capability declaration was needed: TestHook posts the EvaluationSeriesContext itself, and the callback serializer's camel-case policy already renders EnvironmentId as environmentId.

Verified with a local build of the harness branch against the server contract test service (net8.0): hooks/evaluation/provides the environment ID passes with no other change.

Describe alternatives you've considered

None; no behavior change is needed.

Additional context

The capability only takes effect once the harness change is released; until then the harness ignores it. The client SDK is untouched.

Link to Devin session: https://app.devin.ai/sessions/bfe54128e2804a96bb100e6120e9a3ef
Requested by: @kinyoklion


Note

Overview
Registers hook-environment-id on the server contract test service’s capability list so the SDK test harness can run the evaluation-hook test that checks evaluationSeriesContext.environmentId.

No SDK or TestHook changes: the harness only runs that scenario when the capability is advertised, and existing serialization already exposes EnvironmentId as environmentId.

Reviewed by Cursor Bugbot for commit bd6557e. Bugbot is set up for automated code reviews on this repo. Configure here.

@kinyoklion kinyoklion self-assigned this Aug 12, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@cursor review

@devin-ai-integration devin-ai-integration Bot added the devin-pr PR was created by Devin AI label Aug 12, 2026
devin-ai-integration Bot and others added 2 commits August 12, 2026 21:55
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion
kinyoklion marked this pull request as ready for review August 12, 2026 22:22
@kinyoklion
kinyoklion requested a review from a team as a code owner August 12, 2026 22:22
@kinyoklion
kinyoklion merged commit c3f087a into main Aug 13, 2026
16 checks passed
@kinyoklion
kinyoklion deleted the devin/1786558601-hook-environment-id-capability branch August 13, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PR was created by Devin AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants