chore: Declare the hook-environment-id contract test capability - #330
Merged
kinyoklion merged 3 commits intoAug 13, 2026
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
kinyoklion
marked this pull request as ready for review
August 12, 2026 22:22
tanderson-ld
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Depends on launchdarkly/sdk-test-harness#410, which adds the
hook-environment-idcapability and a test assertingevaluationSeriesContext.environmentId.Describe the solution you've provided
Only the capability declaration was needed:
TestHookposts theEvaluationSeriesContextitself, and the callback serializer's camel-case policy already rendersEnvironmentIdasenvironmentId.Verified with a local build of the harness branch against the server contract test service (net8.0):
hooks/evaluation/provides the environment IDpasses with no other change.Describe alternatives you've considered
None; no behavior change is needed.
Additional context
The capability only takes effect once the harness change is released; until then the harness ignores it. The client SDK is untouched.
Link to Devin session: https://app.devin.ai/sessions/bfe54128e2804a96bb100e6120e9a3ef
Requested by: @kinyoklion
Note
Overview
Registers
hook-environment-idon the server contract test service’s capability list so the SDK test harness can run the evaluation-hook test that checksevaluationSeriesContext.environmentId.No SDK or
TestHookchanges: the harness only runs that scenario when the capability is advertised, and existing serialization already exposesEnvironmentIdasenvironmentId.Reviewed by Cursor Bugbot for commit bd6557e. Bugbot is set up for automated code reviews on this repo. Configure here.