Skip to content

do not merge ci: stop running the unit test suite twice per build #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abelonogov-ld wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not merge ci: stop running the unit test suite twice per build #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions launchdarkly-android-client-sdk/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,17 @@ android {
useLibrary("android.test.mock")
}

androidComponents {
// This module has no variant-specific source sets, so the release variant's unit tests compile
// and run exactly the same code as the debug variant's. Leaving them enabled makes `check`, and
// therefore every CI run, execute the whole suite twice: it doubles the unit test time and
// doubles the chance of a run tripping a flaky test. Re-enable if a variant-specific difference
// (such as the BuildConfig.DEBUG branch in LDTimberLogging) ever gains unit test coverage.
beforeVariants(selector().withBuildType("release")) { variantBuilder ->
variantBuilder.enableUnitTest = false

@tanderson-ld tanderson-ld Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't we prefer to disable unit tests for the debug build type and enable them for the release build type?

}
}

configurations {
commonClasses {
transitive = false
Expand Down
Loading