fix(base): improve table shortcut behavior & guidance (pre-Jul 17 snapshot)#1940
Draft
huarenmin13 wants to merge 4 commits into
Draft
fix(base): improve table shortcut behavior & guidance (pre-Jul 17 snapshot)#1940huarenmin13 wants to merge 4 commits into
huarenmin13 wants to merge 4 commits into
Conversation
1. assert typed validation and API metadata in error-path tests 2. share field readback result decoration while preserving returned-type precedence 3. cover the review fixes with package, race, E2E, vet, and lint gates ```ai-signature 改动范围: shortcuts/base/field_ops.go、base_execute_test.go、base_shortcuts_test.go，限定为评论指出的结果元数据去重和错误测试强化。 思考过程: CodeRabbit 的共享 helper 建议基于旧实现，当前 update 必须优先读取同次 PUT 返回 type，因此只抽取 metadata decorator；validation 与 API error 分别断言真实分类和参数边界。 改动原因: 闭环 PR1803 中两条 inline 评论及两组 nitpick，避免消息子串测试遗漏错误契约回归，同时不改变任何 CLI 请求或返回语义。 Break Change: 否 ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: c642bc0139c334862c4e354bcc5ed4239c6484dd5d0dd95ffde54f29d0d66cf4
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
domain/base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative snapshot of #1803 before the Jul 17 follow-up series. This branch points to
746299219e1716faa7e0ce24cb0a7ff06532eb6f, the first parent ofddd5e037c48cda94901f766125ce140ea745a8b1.This PR was created from a new branch and does not modify #1803 or its
table-review-fixes-prbranch.Intentionally excluded commits
ddd5e03fix(base): address review feedback and sync main340ca05fix(base): preserve projection error parameters995a5e7test(base): align projection error coveragefe8c22btest(base): reduce review test duplicationb42b5e3fix(base): report only supplied projection flags87252cefix(base): enforce record projection contracts00bbfc0test(base): drop live E2E follow-up0d80e70fix(base): preserve projection error parameters for flag-like field namesDiff scope at creation
Compared with
larksuite/cli@main(05285bb):Validation
746299219e1716faa7e0ce24cb0a7ff06532eb6f.0d80e70bd5cea3af67851b03caef6bfcd9c0932f.