Allow user to set env variables and do not always require a .env file - #4
Open
cmbiwer wants to merge 1 commit into
Open
Allow user to set env variables and do not always require a .env file#4cmbiwer wants to merge 1 commit into
cmbiwer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR:
dict. But if we just let it continue, the user could specify these variables in their environment.There are probably several different things we could do. Raise a warning, have a strict/non-strict mode (i.e. fail if not found but continue if given the option to continue), etc. If you have a preference let me know.
This would be beneficial for setting up a default
LLMS_JSON_FILEthat users can share in a module. With this, then the user does not have to have a local.envfile either, giving them more freedom to freely move around the filesystem and callwolf.