Support loading dataset by tag - #84
Conversation
|
Thanks Destiny, This looks promising, and the existing test suite is passing. Could you rebase onto the current main and rerun CI? The branch predates the current 0.36.0 canonical image, so the latest compatibility path still needs verification. After that, I think this should be ready for approval pending the manual version/tag checks. |
c634f48 to
4adf09a
Compare
For sure, done. |
Removing ENV DATA_PATH=/data breaks every existing deployment. The run command in the README returns 400 instead of the dataset list, and the startup checks in entrypoint.sh are skipped because DATA_PATH is unset. The location field is still available. Set DATA_PATH to an empty value with -e DATA_PATH= to select the database in the UI. The smoke test is back to the mounted-only form. It exists to catch this kind of break, and passing -e DATA_PATH=/data hid it.
lancedb.connect() runs Path(uri).mkdir(parents=True, exist_ok=True) for local paths, so a location that does not exist is created on the server. The viewer never writes to Lance data. A local location that is not a directory now returns an error before connect() is called. Remote URIs skip the check, because connect() creates nothing for s3:// and the other object stores.
|
Thanks for the rebase. The version and tag selection works well. I built a table with two versions and a tag, and I pushed two commits to your branch rather than send you round again. Both are small. If you disagree with either, say so and I will drop it. The first restores Your location mode is still there. It turns on with The second adds a guard before All eight versions in the matrix pass, 42 tests each. |
|
Sounds good, thanks for the change! |
Closes #83
Hi team, in this PR I add multi-version dataset viewing. The viewer continues to load the latest snapshot from
mainby default, while allowing users to select a numeric version or tag for ML experimentation and dataset comparison.Implementation-wise, a few changes
DATA_PATHis not configured.mainfor the latest snapshot1tag:base-snapshotLanding page

Loading dataset by default "main"

Loading dataset by tag and version
