Skip to content

feat: expose shared session APIs - #63

Open
Jay-ju wants to merge 1 commit into
lance-format:mainfrom
Jay-ju:session-api
Open

feat: expose shared session APIs#63
Jay-ju wants to merge 1 commit into
lance-format:mainfrom
Jay-ju:session-api

Conversation

@Jay-ju

@Jay-ju Jay-ju commented Aug 23, 2026

Copy link
Copy Markdown

Summary

  • expose an opaque LanceSession with configurable index and metadata cache limits
  • allow datasets to share a session through lance_dataset_open_with_session while preserving the existing open API
  • expose cache hit, miss, entry, and retained-byte statistics
  • add C++ RAII wrappers, documentation, and lifecycle/cache reuse coverage

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Gate recommendation: approve with a non-blocking risk.

The explicit session handle matches the upstream Lance ownership model, preserves the existing open APIs, and correctly demonstrates metadata-cache reuse and lifetime independence across Rust, C, and C++.

A non-blocking risk remains in the pinned upstream implementation: cache namespaces include the dataset URI but not object-store options. If one session opens the same URI against different physical endpoints, separate sessions are the safe mitigation until store identity is incorporated into the upstream cache key.

@lance-gatekeeper lance-gatekeeper Bot added K-approved Latest Gatekeeper recommendation permits acceptance. K-risk Latest Gatekeeper recommendation includes a non-blocking risk. labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

K-approved Latest Gatekeeper recommendation permits acceptance. K-risk Latest Gatekeeper recommendation includes a non-blocking risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant