Refine Primary region cards#71
Merged
Merged
Conversation
Polish the RegionSummaryCard styling on the Primary tab so it reads less generic: - Progress bar: taller on the big cards (6→10pt, compact stays 6) and a flat tint fill instead of the gradient. - Day count: shrink the hero number (46→40) and enlarge the "days" unit (subheadline→title3) so they read as a balanced pair. - Region name header: larger (fixed 38pt serif), top-aligned so it hugs the top rather than floating against the stamp, tinted to match the day count at 0.8 opacity, natural casing instead of all-caps, tightened tracking, and one-line with allowsTightening + minimumScaleFactor. - Drop the emoji from the card header (kept elsewhere it's used).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishes the
RegionSummaryCardstyling on the Primary tab so it reads less generic and more like an intentional passport-stamp card.Changes
progressBarHeight6 → 10pt; compact Elsewhere cards keep 6 via a newprogressBarHeightCompact), and a flatstyle.tintfill instead of the gradient.heroNumberFontSize46 → 40) and enlarge the "days" unit (.subheadline→.title3on Primary) so the number and unit read as a balanced pair rather than a huge number next to tiny text.deviceWidth − 188), the common names ("California" ~183pt, "New York" ~173pt) fit fully even on the smallest iPhone; over-long names tighten then scale viaminimumScaleFactor(0.7)rather than wrapping or overlapping the stamp.style.tint) at0.8opacity so it picks up a bit of the card behind it.-0.5), and kept to one line withallowsTightening.Notes
RegionSummaryCard+UIConstants; no logic, public API, or tests touched..largeTitle(which keeps Dynamic Type but makes "California" render noticeably smaller than "New York" between the two stacked cards)../swiftformat --lint(clean). This is UI-only; the iOS test schemes run in CI.