Skip to content

Fix: ticktick tasks update fails with Cannot read properties of undefined (reading 'id') #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leo-ashton wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: ticktick tasks update fails with Cannot read properties of undefined (reading 'id') #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d8bbf4
fix: pass projectId to update command to avoid full-table task search
leo-ashton Jun 24, 2026
0aea5ec
fix: pass correct options arg in tasks.due test calls
leo-ashton Jun 24, 2026
15815e4
fix: handle 204 No Content response from TickTick update API
leo-ashton Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/ticktick.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ async function handleTasks() {
process.exit(1);
}
return await tasks.update(args.positional[0], {
projectId: args.options.project,
title: args.options.title,
content: args.options.content,
dueDate: args.options.due,
Expand Down
16 changes: 11 additions & 5 deletions lib/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ export async function update(taskId, options = {}, deps = {}) {
parseReminder = coreFunctions.parseReminder,
parsePriority = coreFunctions.parsePriority,
} = deps;
const resolvedTaskId = await resolveTaskId(taskId, null, deps);
const projectId = options.projectId || null;
const resolvedTaskId = await resolveTaskId(taskId, projectId, deps);
const input = { id: resolvedTaskId };

if (options.title) input.title = options.title;
Expand All @@ -145,16 +146,21 @@ export async function update(taskId, options = {}, deps = {}) {
}

const task = await apiRequest('POST', `/task/${encodeURIComponent(resolvedTaskId)}`, input, deps);
// API returns 204 No Content on success, re-fetch if we need details
return {
success: true,
task: {
task: task ? {
id: shortId(task.id),
fullId: task.id,
projectId: shortId(task.projectId),
title: task.title,
dueDate: task.dueDate,
priority: formatPriority(task.priority),
tags: task.tags || [],
} : {
id: shortId(resolvedTaskId),
fullId: resolvedTaskId,
title: input.title || '(updated)',
},
};
}
Expand Down Expand Up @@ -466,7 +472,7 @@ async function resolveTaskId(taskId, projectId = null, deps = {}) {
// Search within specific project
try {
const data = await apiRequest('GET', `/project/${encodeURIComponent(projectId)}/data`, undefined, deps);
const match = data.tasks.find((t) => t.id.startsWith(taskId));
const match = (data && data.tasks || []).find((t) => t && t.id && t.id.startsWith(taskId));
if (match) {
return match.id;
}
Expand All @@ -478,10 +484,10 @@ async function resolveTaskId(taskId, projectId = null, deps = {}) {
// Search all projects
const projects = await apiRequest('GET', '/project', undefined, deps);

for (const project of projects) {
for (const project of (projects || [])) {
try {
const data = await apiRequest('GET', `/project/${encodeURIComponent(project.id)}/data`, undefined, deps);
const match = data.tasks.find((t) => t.id.startsWith(taskId));
const match = (data && data.tasks || []).find((t) => t && t.id && t.id.startsWith(taskId));
if (match) {
return match.id;
}
Expand Down
8 changes: 4 additions & 4 deletions test/tasks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ describe('tasks.due', () => {
return {};
});

const result = await tasks.due(7, makeDeps(mockApiRequest));
const result = await tasks.due(7, {}, makeDeps(mockApiRequest));

assert.equal(result.days, 7);
// Should include tomorrow and next week, but not next month, no due date, or completed
Expand Down Expand Up @@ -528,7 +528,7 @@ describe('tasks.due', () => {
return {};
});

const result = await tasks.due(7, makeDeps(mockApiRequest));
const result = await tasks.due(7, {}, makeDeps(mockApiRequest));

assert.equal(result.tasks[0].title, 'Day 1');
assert.equal(result.tasks[1].title, 'Day 2');
Expand All @@ -543,7 +543,7 @@ describe('tasks.due', () => {
return {};
});

const result = await tasks.due(undefined, makeDeps(mockApiRequest));
const result = await tasks.due(undefined, {}, makeDeps(mockApiRequest));

assert.equal(result.days, 7);
});
Expand All @@ -567,7 +567,7 @@ describe('tasks.due', () => {
return {};
});

const result = await tasks.due(7, makeDeps(mockApiRequest));
const result = await tasks.due(7, {}, makeDeps(mockApiRequest));

// Overdue tasks should be included - they're the most urgent
assert.equal(result.count, 2);
Expand Down