Skip to content

Initial cut of external plugin support for NPD#1281

Open
dims wants to merge 1 commit into
kubernetes:masterfrom
dims:initial-cut-of-external-plugin-support-for-npd
Open

Initial cut of external plugin support for NPD#1281
dims wants to merge 1 commit into
kubernetes:masterfrom
dims:initial-cut-of-external-plugin-support-for-npd

Conversation

@dims

@dims dims commented May 13, 2026

Copy link
Copy Markdown
Member

xref: #833

As a first step to GPU support, we want to avoid running scripts repeatedly and have something running that NPD can talk to over GRPC. I did some experiments in:
https://github.com/dims/npd-ext

Filing this PR as a first step. I've included a sample examples/external-plugins/gpu-monitor that just runs nvidia-smi.

NOTE that the protos are based off the same handshake that external plugins currently use. So this mechanism is NOT just for GPUs in any way.

Please see docs/external-plugins.md for more info.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims
Once this PR has been reviewed and has the lgtm label, please assign wangzhen127 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and mrunalp May 13, 2026 14:54
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 13, 2026
Comment thread examples/external-plugins/gpu-monitor/Dockerfile Outdated
@dims dims force-pushed the initial-cut-of-external-plugin-support-for-npd branch 2 times, most recently from fbf84fa to 08a4e88 Compare May 13, 2026 15:09
@dims

dims commented May 14, 2026

Copy link
Copy Markdown
Member Author

/retest

@dims

dims commented May 20, 2026

Copy link
Copy Markdown
Member Author

cc @wangzhen127 @hakman

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2026
@dims dims closed this May 26, 2026
@dims dims reopened this Jun 18, 2026
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the initial-cut-of-external-plugin-support-for-npd branch from 08a4e88 to 49639d2 Compare June 18, 2026 10:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2026
@dims

dims commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/retest

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@dims: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-node 49639d2 link true /test pull-npd-e2e-node
pull-npd-e2e-kubernetes-gce-ubuntu 49639d2 link true /test pull-npd-e2e-kubernetes-gce-ubuntu
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags 49639d2 link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-e2e-kubernetes-gce-gci 49639d2 link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-gci-custom-flags 49639d2 link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants