[occm] test: add loadbalancer servicemonitor regression - #3171
[occm] test: add loadbalancer servicemonitor regression#3171jihyun-huh wants to merge 2 commits into
Conversation
Exercise both the disabled and enabled ServiceMonitor chart paths and verify the ServiceMonitor-to-Service-to-DaemonSet wiring. Run the suite in chart CI with a Helm 3.10-compatible, commit-pinned helm-unittest release.
Keep the metrics example aligned with the chart and the Prometheus Operator configuration covered by the regression test.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jihyun-huh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @gouthampacha @kayrus, could one of you please add |
What this PR does / why we need it:
Hi maintainers,
this PR adds renderering level regression coverage for the OCCM Helm chart ServiceMonitor behavior fixed by #3039
currently, the existing chart CI runs
ct lintwith the default values, whereserviceMonitor.enabledis disabled. and it therefore does not exercise or semantically validate the ServiceMonitor, metrics Service, and DaemonSet wiring.The new tests verify this things:
serviceMonitorcreates matching Service and ServiceMonitor resourcesbearerTokenFileauthentication is not now used/metricsonly when monitoring is enabledreferences:
Which issue this PR fixes(if applicable):
Follow-up to #3039, adds regression coverage for #3144
Special notes for reviewers:
helm-unittestis pinned to the immutablev1.0.3commit, because this is the latest release compatible with the Helmv3.10.0currently used by the chart workflow.The suite passes against current
masterbranch.against the parent of #3039, it fails on the previous selector mismatch, deprecated bearer token configuration, and missing metrics authorization flag.
also, this is a renderering level test and does not require a Kubernetes, Prometheus, or OpenStack environment.
Release note: