Skip to content

[occm] test: add loadbalancer servicemonitor regression - #3171

Open
jihyun-huh wants to merge 2 commits into
kubernetes:masterfrom
jihyun-huh:test/add-loadbalancer-servicemonitor-regression
Open

[occm] test: add loadbalancer servicemonitor regression#3171
jihyun-huh wants to merge 2 commits into
kubernetes:masterfrom
jihyun-huh:test/add-loadbalancer-servicemonitor-regression

Conversation

@jihyun-huh

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Hi maintainers,
this PR adds renderering level regression coverage for the OCCM Helm chart ServiceMonitor behavior fixed by #3039

currently, the existing chart CI runs ct lint with the default values, where serviceMonitor.enabled is disabled. and it therefore does not exercise or semantically validate the ServiceMonitor, metrics Service, and DaemonSet wiring.

The new tests verify this things:

  • add metric resources and public metrics access remain disabled by default
  • enabling serviceMonitor creates matching Service and ServiceMonitor resources
  • the Service selects the OCCM DaemonSet pods
  • update document that deprecated bearerTokenFile authentication is not now used
  • update OCCM exposes and authorizes /metrics only when monitoring is enabled

references:

Which issue this PR fixes(if applicable):
Follow-up to #3039, adds regression coverage for #3144

Special notes for reviewers:

helm-unittest is pinned to the immutable v1.0.3 commit, because this is the latest release compatible with the Helm v3.10.0 currently used by the chart workflow.

The suite passes against current master branch.
against the parent of #3039, it fails on the previous selector mismatch, deprecated bearer token configuration, and missing metrics authorization flag.

also, this is a renderering level test and does not require a Kubernetes, Prometheus, or OpenStack environment.

Release note:

NONE

Exercise both the disabled and enabled ServiceMonitor chart paths and verify the ServiceMonitor-to-Service-to-DaemonSet wiring. Run the suite in chart CI with a Helm 3.10-compatible, commit-pinned helm-unittest release.
Keep the metrics example aligned with the chart and the Prometheus Operator configuration covered by the regression test.
@kubernetes-prow kubernetes-prow Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from kayrus and zetaab August 28, 2026 14:13
@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @jihyun-huh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2026
@jihyun-huh

Copy link
Copy Markdown
Contributor Author

Hi @gouthampacha @kayrus, could one of you please add /ok-to-test when you have a chance? This PR only adds Helm regression coverage for the ServiceMonitor fix merged in #3039. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant