fix: prevent premature stream closure in watch with undici 8.6.0#2933
Open
mstruebing wants to merge 1 commit into
Open
fix: prevent premature stream closure in watch with undici 8.6.0#2933mstruebing wants to merge 1 commit into
mstruebing wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
|
|
kubernetes-prow
Bot
added
the
cncf-cla: no
mstruebing
force-pushed
the
fix-for-undici-8
branch
from
15d9ca5 to
026fb03
Compare
kubernetes-prow
Bot
added
the
size/S
Remove body-level close/finish event listeners that could trigger controller.abort() before readline finished processing buffered data. With undici >= 8.6.0, this premature abort causes remaining response chunks (e.g. DELETED events) to be dropped.
mstruebing
force-pushed
the
fix-for-undici-8
branch
from
026fb03 to
f226e3d
Compare
kubernetes-prow
Bot
added
cncf-cla: yes
Member
Author
|
/ok-to-test |
kubernetes-prow
Bot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove body-level close/finish event listeners that could trigger controller.abort() before readline finished processing buffered data. With undici >= 8.6.0, this premature abort causes remaining response chunks (e.g. DELETED events) to be dropped.