Conversation
Create String Art Generator Website
This commit resolves a workflow failure caused by a deprecated action dependency. The `actions/upload-pages-artifact` action has been updated from `v2` to `v3` to comply with the latest requirements and ensure the deployment workflow runs successfully.
fix(deploy): Update upload-pages-artifact to v3
kolonuk
had a problem deploying
to
github-pages
October 13, 2025 16:29 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This commit resolves a workflow failure where the `configure-pages` action could not find a configured GitHub Pages site. - The `enablement: true` parameter has been added to the `actions/configure-pages@v4` step. - This allows the workflow to automatically enable GitHub Pages for the repository if it's not already active, preventing the 'Not Found' error. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: John Wood <john@kolon.co.uk>
kolonuk
had a problem deploying
to
github-pages
October 13, 2025 16:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
kolonuk
had a problem deploying
to
github-pages
October 13, 2025 16:41 — with
GitHub Actions
Failure
GitHub Actions
Failure
kolonuk
had a problem deploying
to
github-pages
October 13, 2025 16:42 — with
GitHub Actions
Failure
GitHub Actions
Failure
kolonuk
had a problem deploying
to
github-pages
October 13, 2025 16:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
This commit significantly enhances the string art generator based on user feedback. Algorithm Improvements: - The core generation algorithm has been updated to produce higher-quality, more detailed images. - It now prevents the same line from being drawn multiple times, forcing the generator to find new paths and create a more distributed and accurate pattern. - The process of "bleaching" the image data after drawing a line has been refined to better handle light and dark areas. UI/UX Enhancements: - A progress bar overlay is now displayed during the generation process, providing clear visual feedback for this long-running operation. - The "Generate" button is disabled during processing to prevent multiple clicks. - The default number of threads has been increased from 1000 to 3000 to produce a better result out-of-the-box. Technical Changes: - The generation function is now asynchronous, allowing the UI to remain responsive and update the progress bar. - CSS and HTML have been updated to support the new progress bar elements. - Fixed a CSS specificity issue that was causing the progress overlay to block clicks in tests. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: John Wood <john@kolon.co.uk>
This commit delivers a robust, high-quality string art generator by addressing all user feedback and passing a full suite of pre-commit checks. Key Improvements: - **Algorithm Enhancement:** The core generation algorithm has been significantly improved. It now uses a scoring system that factors in both line darkness and line length, preventing the repetitive short-path issue and producing much more accurate and detailed images. - **UI Transparency:** A "Processed Image" canvas has been added to the UI. This shows the user the exact low-resolution, grayscale image that the algorithm is using as a source, making the process much more transparent. - **Workflow Fix:** The GitHub Actions deployment workflow has been corrected to use the non-deprecated `actions/upload-pages-artifact@v4`, ensuring reliable deployments. - **Improved Testing:** A new unit test has been added for the core `generateStringArt` function to catch future regressions. Frontend verification scripts were also refined to be more specific and reliable. This version of the application is now feature-complete, robust, and produces high-quality results as per the user's requirements. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: John Wood <john@kolon.co.uk>
This commit adds explanatory comments to the `.github/workflows/deploy.yml` file. The comments clarify that when a deployment is run for the `dev` branch, a unique preview URL is generated. It explicitly states that this URL can be found in the summary of the workflow run on the 'Actions' tab of the GitHub repository. This is intended to make it easier for users to find the link to their test server/preview environment. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: John Wood <john@kolon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create String Art Generator Website