Skip to content

Fix typings for wrapper packages#400

Merged
maximiliani merged 3 commits into
mainfrom
fix-typings
Jul 2, 2026
Merged

Fix typings for wrapper packages#400
maximiliani merged 3 commits into
mainfrom
fix-typings

Conversation

@craquet

@craquet craquet commented Jul 1, 2026

Copy link
Copy Markdown
Member

Fixes the typings in the react, angular and vue packages.

For some reason my build also changed some quotes in the stencil library src, but I figured I commit it anyway.

@craquet craquet requested a review from maximiliani July 1, 2026 09:07
@craquet craquet added the bug Something isn't working label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🎨 Chromatic Visual Tests

✅ No visual changes

Review

View in Chromatic

Chromatic provides automated visual testing and review for component changes.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.69%. Comparing base (a9e5e5d) to head (43aee5b).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files          50       50           
  Lines        3520     3520           
  Branches     1040     1010   -30     
=======================================
  Hits         2735     2735           
  Misses        783      783           
  Partials        2        2           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Test Results

Coverage Summary

Node Lines Statements Branches Functions

Coverage & Quality Reports

📊 Codecov Report
🎨 Chromatic Status


For more details, check the workflow run

@craquet craquet removed the request for review from maximiliani July 1, 2026 09:13
@craquet

craquet commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

I have no clue how angular works, but with this fix the build as well as the typings look fine

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🎨 Chromatic Visual Tests

✅ No visual changes

Review

View in Chromatic

Chromatic provides automated visual testing and review for component changes.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Test Results

Coverage Summary

Node Lines Statements Branches Functions
22 76.78% 75.70% 62.01% 78.15%
24 76.78% 75.70% 62.01% 78.15%
25 76.78% 75.70% 62.01% 78.15%

Coverage & Quality Reports

📊 Codecov Report
🎨 Chromatic Status


For more details, check the workflow run

@craquet craquet requested a review from maximiliani July 1, 2026 10:30
@maximiliani maximiliani merged commit fec91e4 into main Jul 2, 2026
10 checks passed
@maximiliani maximiliani deleted the fix-typings branch July 2, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants