chore: audit polish batch (citation ranges, power per-arm N, judge raw_decode, engine count)#5
Open
kicrazom wants to merge 4 commits into
Open
chore: audit polish batch (citation ranges, power per-arm N, judge raw_decode, engine count)#5kicrazom wants to merge 4 commits into
kicrazom wants to merge 4 commits into
Conversation
…ndant set Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…atio!=1) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…extraction Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ADMAP) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-priority cleanups from the audit, batched as atomic commits. No behavior change beyond the two stated fixes.
citation_parse— marker parse now expands[1-3]ranges and[1,2,5]lists (was[n]only → false orphans); also drops the redundantcited = set(markers)rebuild.power_sample_size—two_sample_tnow surfacesn_group1/n_group2(they differ whenratio != 1; group-2 was folded inton_totalonly, risking under-enrolment of the larger arm). Schema updated.judge_behavior— the 25-line string-aware brace scanner replaced byjson.JSONDecoder.raw_decode(stdlib does the same, and only accepts a{that begins valid JSON).main()engines inscripts/core/) in the envelope-contract test docstring, STATUS, ROADMAP. CHANGELOG left as historical record.Tests: +2 (citation ranges/lists, power per-arm N). Full suite green (174 passed, 1 skipped); ruff clean.
Deliberately NOT done
rag/cagKB stubs and theVllmBackendscaffold are left in place — declared roadmap (NotImplementedError("v3")/ labelled unvalidated), consistent with the egress "keep + build" decision. Not vaporware to hide, just not deleted.🤖 Generated with Claude Code