docs(stat_run): record deterministic-core rationale (why not scipy/statsmodels)#4
Open
kicrazom wants to merge 1 commit into
Open
docs(stat_run): record deterministic-core rationale (why not scipy/statsmodels)#4kicrazom wants to merge 1 commit into
kicrazom wants to merge 1 commit into
Conversation
… deterministic-core Record why they reimplement scipy/statsmodels rather than wrap them (byte-stable across library versions + envelope provenance fields), so the reimplementation is not "simplified" away. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last open item from the audit.
permutation_test/multiple_testingwere flagged as reimplementing scipy/statsmodels (already deps). Verdict: keep — the correctness audit found no bug in them, and reimplementation is the deterministic-core contract (byte-stable output independent of library version, plus envelope provenance fields scipy doesn't expose).Doc-only: one rationale line in each docstring so the reimplementation isn't mistaken for incidental duplication and "simplified" back to a wrapper. No behavior change.
🤖 Generated with Claude Code