fix(adk): keep token refresh loop alive after a failed read#2330
Open
mesutoezdil wants to merge 2 commits into
Open
fix(adk): keep token refresh loop alive after a failed read#2330mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
_refresh_token only handled a token read returning None. Any other exception from the read (not just the OSError already handled inside read_token) escaped the while loop and killed the background task for the rest of the process, with no restart. The token would never refresh again after that. Now a failed read is logged and the loop keeps going on its next 60s cycle. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…p-resilience Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_refresh_token only handled a token read returning None. Any other exception from the read (anything other than the OSError already handled inside read_token) escaped the while loop and killed the background refresh task for the rest of the process, no restart, no backoff. The token would never refresh again after that, easy to miss since the task is never awaited elsewhere.
Now a failed read is logged and the loop keeps going on its next 60s cycle instead of dying.
Added a test that fails the first read, then succeeds on the second, and checks the loop is still alive and the token still updates. Confirmed it fails against the old code (loop dies on the first exception) and passes with the fix.