fix(adk): keep full session state when num_recent_events is set#2329
Open
mesutoezdil wants to merge 2 commits into
Open
fix(adk): keep full session state when num_recent_events is set#2329mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
get_session only fetched the last N events when num_recent_events was set, then built session.state by replaying just those N events. Any state_delta set by an older event outside that window never made it into state, silently. Now the full event history is always fetched to build state, and num_recent_events only trims the events list returned on the session, after state is already correct. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-recent-events Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_session only fetched the last N events when num_recent_events was set, then built session.state by replaying just those N events. Any state_delta set by an older event outside that window never made it into state, silently, no error.
Now the full event history is always fetched to build state, and num_recent_events only trims the events list on the returned session, after state is already correct.
Added a test with a mock server that respects the limit query param, confirmed it fails against the old code and passes with the fix.