fix(ui): stop stale session load from overwriting the active chat#2328
Open
mesutoezdil wants to merge 2 commits into
Open
fix(ui): stop stale session load from overwriting the active chat#2328mesutoezdil wants to merge 2 commits into
mesutoezdil wants to merge 2 commits into
Conversation
ChatInterface is not remounted on session switch, so the load effect for the old session was still running when a new session was picked. If the old fetch resolved after the new one, its messages silently replaced the new session's messages on screen. Added a cancelled flag, same pattern already used by the other effect in this file, so a stale load exits before touching state. Added a test that reproduces the race with out of order responses. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…ch-race Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatInterface is not remounted when the session id prop changes, so the message-load effect for the old session keeps running after a new session is picked. If the old fetch resolves after the new one (plausible under normal network jitter), its response silently overwrites the new session's messages on screen, no error shown, wrong conversation visible.
Added a cancelled flag to the effect, same pattern already used by the neighboring effect in this file, so a stale load exits before touching state.
Added a test that reproduces the race with out of order responses, confirmed it fails against the old code and passes with the fix.