feat: add envFrom support to agent deployment spec#2321
Open
uncycler wants to merge 1 commit into
Open
Conversation
Signed-off-by: Frédéric Marchand <frederic.marchand@kudelskisecurity.com>
EItanya
requested changes
Jul 23, 2026
Comment on lines
+458
to
+459
| // +optional | ||
| EnvFrom []corev1.EnvFromSource `json:"envFrom,omitempty"` |
Contributor
There was a problem hiding this comment.
Why is this necessary? Env above already has ValueFrom support
Author
There was a problem hiding this comment.
These solve different problems. env + valueFrom binds a single ConfigMap/Secret key to a single env var, so every key has to be listed explicitly. envFrom imports all keys from a ConfigMap/Secret at once, using each key as the variable name.
The use case is a ConfigMap/Secret whose key set isn't fixed (populated from an external system, like external secret operator), where enumerating keys in the spec isn't practical. Same reason upstream PodSpec exposes both.
Contributor
|
looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
envFromfield to the agent deployment spec so users can populatecontainer environment variables from entire ConfigMaps/Secrets (Kubernetes'
native
envFrom), instead of enumerating each key viaenv.Fix
Add EnvFrom []corev1.EnvFromSource to SharedDeploymentSpec and wire it
through the translator to the pod container, exactly parallel to the existing
Testing
New unit tests assert EnvFrom propagation for both BYO and declarative specs.