fix(build): use AZURE_OPENAI_API_KEY env var name consistently#2310
Merged
Conversation
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Aligns Azure OpenAI API key environment variable naming across build tooling and Helm docs to prevent helm-install from passing an empty Azure key.
Changes:
- Rename Makefile references from
AZUREOPENAI_API_KEYtoAZURE_OPENAI_API_KEY. - Update Helm README export examples to use
AZURE_OPENAI_API_KEY.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| helm/README.md | Updates environment-variable examples to match the code’s expected Azure OpenAI key name. |
| Makefile | Uses AZURE_OPENAI_API_KEY for validation and Helm --set injection to avoid empty Azure key values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
reviewed
Jul 21, 2026
EItanya
left a comment
EItanya
left a comment
Contributor
There was a problem hiding this comment.
Good catch, I thought we changed these already a while back
EItanya
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile checked and passed AZUREOPENAI_API_KEY while the Go and Python code read AZURE_OPENAI_API_KEY, so the helm-install targets silently passed an empty Azure key. This renames the Makefile variable and the two helm README export examples to match the code. Split out of #2144 since it changes Makefile behavior rather than docs.