chore(build): fix stale node version comments in python full image#2236
Open
mesutoezdil wants to merge 16 commits into
Open
chore(build): fix stale node version comments in python full image#2236mesutoezdil wants to merge 16 commits into
mesutoezdil wants to merge 16 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Python “full” runtime Docker image with the rest of the repo by pinning its Node base image to Node 24 (instead of Node 26), keeping the sandbox-runtime-compatible Debian Bookworm slim base while maintaining digest pinning.
Changes:
- Update
python/Dockerfile.fullbase image fromnode:26-bookworm-slim@...tonode:24-bookworm-slim@... - Refresh the accompanying inline documentation to reference Node 24 and the corresponding imagetools inspect command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mesutoezdil
force-pushed
the
fix/python-dockerfile-node-version
branch
4 times, most recently
from
July 15, 2026 19:02
05097b0 to
f7f176c
Compare
node:26 didn't match node 24 used everywhere else in the repo. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/python-dockerfile-node-version
branch
from
July 15, 2026 20:10
f7f176c to
d3cb434
Compare
…-node-version # Conflicts: # python/Dockerfile.full
mesutoezdil
changed the title
github-actions
Bot
added
ignore-for-release
and removed
bug
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
…-node-version Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main moved the base image to node 26 but the comments above the FROM line still say node 20. This updates them to match the actual pinned image.
The original intent of this PR was pinning to node 24, that is obsolete now that main is on node 26.