fix: ignore notes belonging to deleted notebooks#27
Merged
Conversation
Collaborator
Author
|
This one is a simple bug fix and the code is also clean and the scope is limited. also I have tested the changes so merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing the plugin locally and found this issue. I had only 50 notes, and the plugin fetched 100 notes.
Problem: When notes or notebooks are deleted, Joplin retains the note records in the SQLite database temporarily for synchronization tracking. Calling joplin.data.get(['notes']) retrieves all note records (including these orphaned/deleted notes), causing the plugin to process and display deleted notes that do not appear in the active Joplin notebook tree.