feat: Auto-name clusters and allow renaming them#25
Conversation
|
Auto-naming the clusters took a few tries to get right:
|
|
Hi! Thank you for this PR, before reviewing there are some merge conflicts. Let me know when you resolve all the conflicts 👍 |
HahaBill
left a comment
There was a problem hiding this comment.
Looking at this PR, I think for releasing the first version for getting feedback from the community is good enough.
There are couple of issues that I can see but we can address them after the midterm evaluation since the plan was to focus on releasing the the first version of this plugin before/during the midterm evaluation. Also, we are ahead of the schedule that you wrote in your proposal :)
Since this version of the plugin is still under the development and unoptimal, then I'd suggest semantically version this as 0.1.0. Look this link explaning what is semantic versioning: https://semver.org/. Then you release small patches from user feedback with smart versioning like 0.1.1.
After resolving conflicts, this can be merged to the main branch.
|
Thanks for the review! Regarding the first release, I think I'll need about one more week. There are a few basic things I'd like to finish first. For example, the plugin currently shows the suggested changes, but there's no way for users to apply them yet. I also want to clean up the UI and make a few minor improvements here and there. I think it would be better to release v0.1.0 next week after these are done, rather than shipping with these rough edges. Also, the Joplin API we're relying on hasn't been released to users yet, so I think waiting another week makes sense. |
Alright, let's discuss this during our weekly call. In a meantime, I'm merging this into the |
Instead of showing "Cluster 1", "Cluster 2", etc., clusters now get real names based on what's actually inside them.
How it works:
Renaming:
Screenshot: