fix(supported): collapse brand typos (Reddragon, Eyooso) onto canonical names - #2
Merged
Conversation
Reddragon and Eyooso catalog submissions previously surfaced as separate brand groups. canonicalBrand() now folds free-text variants onto the canonical names (Redragon, E-YOOSO) used by the static table, and the Eyooso row is renamed to E-YOOSO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Fixes brand names on the supported-devices page: - Live catalog submissions carrying free-text manufacturer typos no longer create duplicate brand groups. A new
canonicalBrand()mapsReddragon->RedragonandEyooso/e-yooso->E-YOOSO, and is applied both to the merge key and topending/supportedrows created from the catalog. - The static rowEyooso X-44 Liteis renamed toE-YOOSO X-44 Lite(the official brand name includes the hyphen). - All other brands were audited against official sources (no further name errors found). ## Verification -npm test: 81 pass -npm run build: clean