Add configurable sandbox storage path#70
Open
markus-24 wants to merge 1 commit into
Open
Conversation
Let users choose where a VM's VHDX is created instead of always using the default location under C:, addressing the common "not enough space on C:" problem (jamesstringer90#24, jamesstringer90#58). - New optional "Storage Folder" field in the create-sandbox modal, with a Browse button (IFileOpenDialog) wired through the webview2 bridge. - storage_folder added to AsbVmConfig/VmConfig; vhdx_dir construction branches on it when set and falls back to the default otherwise. - Validation of the chosen folder: path syntax, drive existence, length, creatability, and a guard against an existing disk at the target. - HDD size line shows the free space of the selected drive, refreshed as the field changes.
|
im new to github and how do i download this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional Storage Folder to the create-sandbox flow, so a VM's VHDX can be created on a drive other than the default
%ProgramData%\AppSandboxlocation. This addresses the common "not enough space on C:" situation.Closes #24. Related: #58.
Changes
Browse…button backed by anIFileOpenDialogfolder picker.storage_folderadded toAsbVmConfig/VmConfig;vhdx_dirconstruction branches on it when set and falls back to the default otherwise. Templates always remain in ProgramData.validate_storage_folder) — absolute path, local fixed drive (no network/removable), length fitsMAX_PATH, target folder is creatable (recursively, viaSHCreateDirectoryExW), and no existingdisk.vhdxalready at the target.Compatibility
Testing
AppSandboxproject,Release|x64(MSVC v143) on top of currentmain(v0.1.3).web/app.jspassesnode --check.Single commit, branched off
main.