Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses stremio-native#34 by making the
/proxyroute failclosed against SSRF, DNS rebinding, credential leakage, recursive self-proxying,
and unbounded response/playlist resource use while preserving the installed
Stremio Server 4.20.15 proxy contract where it is safe.
This PR:
every redirect hop;
by default, including mapped IPv4, NAT64/Pref64, scoped IPv6, and mixed-answer
bypasses;
upstream TLS certificates, exposed through the tray/GUI, API, settings file,
and environment variables;
safe raw/effective settings persistence;
origins, pins a no-proxy client, and prevents public caching of credentialed
responses;
per-peer/global admission, read-idle, response-header, collection, delivery,
and downstream-stall lifetimes;
installed playlist line delimiters;
opaque crash dumps from exported ZIP files;
differences, and residual risks in
docs/network-source-security.md.Secure defaults and intentional differences
Private/LAN destinations and invalid upstream TLS certificates remain disabled
by default. Metadata and the server's own listeners are always denied. Cross-
origin redirects discard every caller-supplied custom request header, not only
the legacy credential names. RFC redirect method semantics and RFC-relative URL
resolution replace observable legacy bugs. Rewritten playlists are limited to
complete transformable
200representations; partial orno-transformresponses stream unchanged.
The application-layer policy is intentionally scoped to
/proxy; it does notclaim to secure every outbound URL sink or make the unauthenticated service safe
for public exposure. It does not alter Windows Firewall rules.
Verification
Fresh local verification on
0a4d362749b2543c4d2ff3e016ee2ae13600f33b:smoke, 8 proxy-security integrations, and doc tests passed (one intentional
FFmpeg download test ignored);
-D warnings,cargo fmt --check, release-notetests (6/6), and
git diff --checkpassed;redirect, self-listener, cancellation, and diagnostic-redaction smoke passed;
32518158264passed native libtorrent workspace Clippy/tests andall-target librqbit Clippy/tests on Ubuntu.
The fork PR's successful Ubuntu check supplies the native libtorrent and
Unix-only platform evidence unavailable on this Windows workstation.
Scope
This branch is based on the fork's
master, including its previously mergeddependency upgrades. Any later upstream submission will be a separately
reviewed clean replay based on
stremio-native/stream-server:master; no upstreambranch or PR is created by this fork submission.