feat: SliderGallery component for interactive content switching#255
Merged
Conversation
Adds a SliderGallery component to the viewer's component registry.
It renders a Mantine Slider that shows/hides child nodes based on
the slider value — each child has a `value` prop, and only the
child matching the current slider position is rendered.
Props: min, max, step, defaultValue, label (format string with
{value} placeholder), marks (tick labels).
Children: array of component nodes, each with a `value` prop.
The nearest-value child is displayed when the slider moves.
Use case: boards that want to show different visualizations at
different parameter values (e.g., tile clustering at K=10 vs K=500).
ivanmkc
force-pushed
the
feat/slider-gallery
branch
from
562e6c5 to
7984156
Compare
The component resolver pre-resolves children into React elements before mounting SliderGallery. Calling resolve(active) on an already-resolved element hits the "missing type" error branch (React element.type is a function, not a string). Use isValidElement() to extract the value prop and render the matched child directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SliderGalleryto the component registryvalueprop; nearest match is renderedUsage
{ "type": "SliderGallery", "props": {"min": 10, "max": 500, "step": 10, "defaultValue": 60, "label": "K = {value}"}, "children": [ {"type": "Image", "props": {"src": "...", "value": 10}}, {"type": "Image", "props": {"src": "...", "value": 60}}, {"type": "Image", "props": {"src": "...", "value": 100}} ] }Test plan
npm run buildsucceeds