Fix Docker build: copy patches/ before pnpm install (#37)#669
Open
joltcan wants to merge 1 commit into
Open
Conversation
pnpm reads patchedDependencies (readabilitySAX@1.6.1) at install time, but the patches/ directory was not copied into the image before 'pnpm install --frozen-lockfile', causing ENOENT and a failed build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Category: Docker
About the changes
What has changed
Docker build was broken due to missing
patches/directory at install time.pnpm reads
patchedDependencies(readabilitySAX@1.6.1) at install time, but thepatches/directory was only copied later viaCOPY . /iframely, causingENOENTand a failed build.Fixed by adding
COPY patches/ /iframely/patches/beforepnpm install --frozen-lockfile, alongside the existing layer-cache copies ofpackage.jsonandpnpm-lock.yaml.Related PRs in other repos
None
Checklist
Review
Single-line Dockerfile change, no migration steps or release notices required. Low risk.