fix: fill in missing translations and correct mistranslations - #139
Merged
Conversation
Six languages had strings left at the "new" state, so they fell back to English in the UI: Hungarian showed the untranslated no-internet alert message, and Turkish, Vietnamese, Korean, Traditional Chinese and Romanian were missing the unit formats and metadata field labels that every other language already carries. "Mono" was translated as "monochrome" in Greek, Finnish and Dutch, and Finnish rendered "Codec" as "code". Mono now matches how each of those languages already writes the paired Stereo label. The nil case of RemuxAlertTitle used a straight apostrophe, which forked "Couldn't Open File" off from the fully translated "Couldn’t Open File" used by the three other call sites and left that alert untranslated in every language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every string now has a translated value in all 22 languages.
Missing translations
Six languages had strings sitting at the
newstate, which falls back to English at runtime:Album,OK,HDR,Front Row, and the five unit formatsFront Row,HDR,ID,Mono,Stereo,Video, and the unit formatsAlbum,Codec,Front Row,HDR,ID,Mono,OK,Stereo,Video, and the unit formatsHDR,ID, and the unit formatsHDR,ID, and the unit formats%@ kbpsOnly the Hungarian alert message needed real prose —
A Mac nincs csatlakoztatva az internethez. Csatlakozzon egy hálózathoz, majd próbálja újra., in the formal register the rest of the Hungarian strings use. The remainder are terms the other sixteen to twenty-one languages already keep in Latin script, and each one was matched to what those languages settled on.Mistranslations
Monolabels single-channel audio, but three languages had translated it as monochrome:MonoMonoMonoCodecMono keeps the Latin form in all three because each of those languages already renders the paired
Stereothat way, and the inspector shows the two side by side.Straight apostrophe
The
nilcase ofRemuxAlertTitleused"Couldn't Open File"with a straight apostrophe. That forked it off from"Couldn’t Open File"— already translated in all 22 languages and used by the three other call sites — so that alert appeared in English everywhere. #137 corrected the other alerts but missed this one. The stale key had no localizations to lose.Note
The branch also carries the Crowdin sync that was sitting uncommitted in the working tree:
stateflips toneeds_reviewon“%@” is on “%@”, which isn’t connected.across all 22 languages. Splitting it out of the same JSON file wasn't practical.Two of those
needs_reviewvalues look worth a Crowdin pass, though this PR leaves them alone: the Arabic one opens with no leading quotation mark (%1$@" هو على "%2$@"), and the Dutch one uses straight'…'instead of the curly marks Dutch writes.Testing
xcodebuild clean analyze testandswift-format lint -s -p -r ./both pass.