This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Requirement version resolution fix#694
Draft
omesser wants to merge 8 commits into
Draft
Conversation
omesser
force-pushed
the
fix_version_collection
branch
from
July 13, 2023 20:50
ba16dd6 to
4602696
Compare
omesser
force-pushed
the
fix_version_collection
branch
from
July 13, 2023 21:33
4602696 to
b33f112
Compare
omesser
force-pushed
the
fix_version_collection
branch
from
July 13, 2023 21:39
b33f112 to
0266c81
Compare
omesser
marked this pull request as draft
July 22, 2023 22:00
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 82.71% 82.64% -0.07%
==========================================
Files 109 109
Lines 9943 9948 +5
==========================================
- Hits 8224 8222 -2
- Misses 1719 1726 +7
☔ View full report in Codecov by Sentry. |
omesser
force-pushed
the
fix_version_collection
branch
from
July 31, 2023 16:19
2a162d8 to
2059f21
Compare
Contributor
Author
|
I forgot about this for a few weeks but came back to this today and fixed the tests, with intention of merging this and releasing to fix #688 |
omesser
marked this pull request as draft
August 23, 2023 14:34
Contributor
Author
|
Seems that CI is broken (not related to changes here, see example in this test PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
importlib.metadata's distribution to extract package versionscloses: #688