Skip to content

fix: handle Bazel load statements in extension-check#7083

Open
immanuwell wants to merge 1 commit into
istio:masterfrom
immanuwell:fix/extension-check-load-statements
Open

fix: handle Bazel load statements in extension-check#7083
immanuwell wants to merge 1 commit into
istio:masterfrom
immanuwell:fix/extension-check-load-statements

Conversation

@immanuwell

Copy link
Copy Markdown
Member

What this PR does / why we need it:
tools/extension-check blows up on normal Bazel config files because the embedded Starlark runner does not handle load(...).

This strips top level load(...) statements before evaluation, returns regular errors instead of panics, and removes the README workaround. Pretty small fix, but it makes the tool usable out of the box.

Which issue this PR fixes:
N/A, this repo has issues disabled.

Special notes for your reviewer:
Repro before this patch:
go run ./tools/extension-check --envoy-extensions-build-config ./bazel/extension_config/extensions_build_config.bzl --proxy-extensions-build-config ./bazel/extension_config/extensions_build_config.bzl --ignore-extensions ./tools/extension-check/wellknown-extensions

Before:
panic: load not implemented by this application

After:
it loads the checked-in file and reaches the normal missing-extension output. so yeah, this is a real bug on a real file, not some weird edge case.

Checks:
go test ./tools/extension-check
go test ./... -run '^$'

@immanuwell immanuwell requested a review from a team as a code owner June 7, 2026 11:32
@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @immanuwell! This is either your first contribution to the Istio proxy repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @immanuwell. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants