fix: add UNSPECIFIED zero values to ConnectionSettings enums#3725
Merged
Conversation
Signed-off-by: Cameron Garrison <cgarriso@redhat.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/S
Collaborator
|
@cam-garrison: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
|
is this released or not? if so, this seems to be a breaking change. |
Contributor
|
Not released yet; just merged last week. LGTM |
keithmattix
approved these changes
Jun 12, 2026
zirain
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in recent PR I made #3707 while writing wiring code in istio/istio. HttpHeadersWithUnderscoresAction and HttpPathWithEscapedSlashesAction use bare enums whose zero values (ALLOW, KEEP_UNCHANGED) are indistinguishable from "unset".
This adds Add
HEADERS_WITH_UNDERSCORES_UNSPECIFIED = 0andPATH_WITH_ESCAPED_SLASHES_UNSPECIFIED = 0to the twoConnectionSettingsenums introduced in above PR.Wire-breaking change to enum numbering, should be safe since ConnectionSettings has not shipped in any release.