feat(tracing): add otel always_on sampler#3722
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @davidspek! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @davidspek. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
268967f to
5a580bd
Compare
|
what's the different with 100% sampling rate? |
|
@zirain The difference is that the always_on sampler will change the propagated trace header to indicate that it's sampled. We have issues with an external party passing trace headers that aren't sampled on their side, causing our internal spans to also not be sampled resulting in loss of observability data. |
|
/ok-to-test |
Fixes: istio/istio#60500
This PR adds configuration support for the OpenTelemetry
always_ontrace sampler. This sampler has been part of the Istio proxy build for 2 years already, but has never been exposed in the configuration.