Skip to content

feat(tracing): add otel always_on sampler#3722

Open
davidspek wants to merge 1 commit into
istio:masterfrom
davidspek:feat/otel-always-on-sampler
Open

feat(tracing): add otel always_on sampler#3722
davidspek wants to merge 1 commit into
istio:masterfrom
davidspek:feat/otel-always-on-sampler

Conversation

@davidspek

Copy link
Copy Markdown

Fixes: istio/istio#60500

This PR adds configuration support for the OpenTelemetry always_on trace sampler. This sampler has been part of the Istio proxy build for 2 years already, but has never been exposed in the configuration.

@davidspek davidspek requested a review from a team as a code owner June 9, 2026 07:53
@istio-policy-bot

Copy link
Copy Markdown

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @davidspek! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jun 9, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @davidspek. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
@zirain

zirain commented Jun 9, 2026

Copy link
Copy Markdown
Member

what's the different with 100% sampling rate?

@davidspek

Copy link
Copy Markdown
Author

@zirain The difference is that the always_on sampler will change the propagated trace header to indicate that it's sampled. We have issues with an external party passing trace headers that aren't sampled on their side, causing our internal spans to also not be sampled resulting in loss of observability data.

@zirain

zirain commented Jun 10, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more samplers in the OpenTelemetry ExtensionProvider config

4 participants