Skip to content

Fix sliders & cycling controllers 26.3+ by using constants for mouse buttons (Fixes #348) #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isXander merged 1 commit into from
Aug 17, 2026
Merged

Fix sliders & cycling controllers 26.3+ by using constants for mouse buttons (Fixes #348) #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/dev/isxander/yacl3/gui/controllers/cycling/CyclingControllerElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,12 @@ public void cycleValue(int increment) {
}

@Override
public boolean mouseClicked(MouseButtonEvent event, boolean doubleClick) {
if (!isMouseOver(event.x(), event.y()) || (event.button() != 0 && event.button() != 1) || !isAvailable())
public boolean mouseClicked(@NonNull MouseButtonEvent event, boolean doubleClick) {
if (!isMouseOver(event.x(), event.y()) || (event.button() != InputConstants.MOUSE_BUTTON_LEFT && event.button() != InputConstants.MOUSE_BUTTON_RIGHT) || !isAvailable())
return false;

playDownSound();
cycleValue(event.button() == 1 || event.hasShiftDown() || event.hasControlDown() ? -1 : 1);

cycleValue(event.button() == InputConstants.MOUSE_BUTTON_RIGHT || event.hasShiftDown() || event.hasControlDown() ? -1 : 1);
return true;
}

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/dev/isxander/yacl3/gui/controllers/slider/SliderControllerElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected void extractValueText(GuiGraphicsExtractor graphics, int mouseX, int m

@Override
public boolean mouseClicked(@NonNull MouseButtonEvent event, boolean doubleClick) {
if (!isAvailable() || event.button() != 0 || !isHoveredSliderBounds(event.x(), event.y()))
if (!isAvailable() || event.button() != InputConstants.MOUSE_BUTTON_LEFT || !isHoveredSliderBounds(event.x(), event.y()))
return false;

mouseDown = true;
Expand All @@ -78,7 +78,7 @@ private boolean isHoveredSliderBounds(double mouseX, double mouseY) {

@Override
public boolean mouseDragged(@NonNull MouseButtonEvent event, double dx, double dy) {
if (!isAvailable() || event.button() != 0 || !mouseDown)
if (!isAvailable() || event.button() != InputConstants.MOUSE_BUTTON_LEFT || !mouseDown)
return false;

setValueFromMouse(event.x());
Expand Down
Loading