fix: bump launcher ROCm torch index from rocm6.3 to rocm7.1#9337
Open
chejh-amd wants to merge 2 commits into
Open
fix: bump launcher ROCm torch index from rocm6.3 to rocm7.1#9337chejh-amd wants to merge 2 commits into
chejh-amd wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pins.jsonstill points the linuxrocmtorch index athttps://download.pytorch.org/whl/rocm6.3, whilepyproject.tomlhas already moved thetorch-rocmindex torocm7.1. So the launcher installs rocm6.3 wheels even though the source/pip install uses rocm7.1. This is the mismatch reported in #9328 (the launcher runs--index=https://download.pytorch.org/whl/rocm6.3).This is especially broken on RDNA4: rocm6.3 wheels predate gfx1201 support (RDNA4 needs ROCm 7.0+), so they can't work on cards like the RX 9070 XT / R9700 at all.
This bumps the
rocmentry inpins.jsontorocm7.1so the launcher matchespyproject.toml.Tested on AMD Radeon AI PRO R9700 (gfx1201, RDNA4), Linux:
pip install torch torchvision --index-url https://download.pytorch.org/whl/rocm7.1→torch 2.12.1+rocm7.1,torch.cuda.is_available()= True (AMD Radeon AI PRO R9700)Fixes #9328.