[raft/config] Control config changes#1573
Draft
MariemBaccari wants to merge 22 commits into
Draft
Conversation
the-glu
reviewed
Jun 29, 2026
| const raftAdminAddrFlag = "raft_admin_addr" | ||
|
|
||
| func init() { | ||
| flag.StringVar(&adminAddr, raftAdminAddrFlag, "", "If set and the raft store backend is in use, determines the address and port for the raft admin endpoint (POST /admin/members), used to add/remove/update a node across all of the rid/scd/aux raft clusters in a single request. Disabled if empty.") |
Member
There was a problem hiding this comment.
It should be enabled by default no?
| registry: globalRegistry, | ||
| } | ||
|
|
||
| adminServer.httpServer = &http.Server{ |
Member
There was a problem hiding this comment.
It should have a form of authentification no? Even with listen address restricted to 127.0.0.1 that not safe enough.
barroco
added
the
dss-raft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
raftctlcli that can add / update and remove nodes from the raft cluster.