chore: Ruby 3.3+ floor, modern GHA, gemspec hygiene - #755
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Add 'standard' gem + .standard.yml (lib/ only; spec/bin/exe ignored) - Auto-fix 953 -> 23 remaining violations (mostly regexp_converter.rb and visualize/*.rb; need manual review) - Add StandardRB job to rake.yml CI
Comment on lines
+11
to
+48
| name: Test on Ruby ${{ matrix.ruby }} / ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| continue-on-error: true | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: [ 3.3, 3.2, 3.1, "3.0", 2.7, 2.6 ] | ||
| os: [ ubuntu-latest, windows-latest, macos-latest ] | ||
| ruby: ["3.3", "3.4"] | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| env: | ||
| BUNDLE_WITHOUT: "secryst" | ||
| SKIP_JS: "1" | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
| - name: Checkout monorepo | ||
| uses: actions/checkout@v7 | ||
| with: | ||
| repository: interscript/interscript | ||
|
|
||
| - name: Run bootstrap script | ||
| - name: Bootstrap packages | ||
| run: ruby bootstrap.rb | ||
|
|
||
| - name: Use Ruby | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| bundler-cache: true | ||
| working-directory: ruby | ||
|
|
||
| - name: Run RSpecs | ||
| working-directory: ./ruby | ||
| - name: Install Python helper and gems | ||
| working-directory: ruby | ||
| run: | | ||
| pip install regex | ||
| bundle install --with=jsexec | ||
| bundle exec rspec | ||
|
|
||
| - name: RSpec | ||
| working-directory: ruby | ||
| run: bundle exec rspec | ||
|
|
||
| standard: |
Comment on lines
+49
to
+57
| name: StandardRB | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "3.4" | ||
| bundler-cache: true | ||
| - run: bundle exec standardrb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_ruby_versionto>= 3.3.0; CI matrix3.3+3.4(drops 2.6/2.7/3.0/3.1/3.2)git ls-filespackaging with explicitDir[]globs (dropsbin/,Gemfile,Rakefile,.github/from gem; 67 files vs. many more before)changelog_uri,bug_tracker_uri,rubygems_mfa_required#!/usr/bin/env rubyshebang toexe/interscriptandchmod +x(resolves "missing #! line" warning; installed binary is now executable)rake ~> 13.0,rspec ~> 3.13, drop obsoleteRUBY_VERSION < 2.7guardactions/checkout@v7,actions/setup-node@v7,ruby/setup-ruby@v1withbundler-cache: true; Node 22 in releaseassets.yml: pinthedoctor0/zip-release@v0.7.6(was@master),svenstaro/upload-release-action@v2(was2.2.1), Ruby 3.3 (was 3.0)rake.yml: dropcontinue-on-error: trueso real failures block mergesTest plan
gem build interscript.gemspecsucceeds with no warnings; 67 files;required_ruby_version >= 3.3.0gem release --pretendreportsrelease interscript 2.4.5→cleanupbin/,Gemfile,Rakefile,.github/Notes
actions/checkoutwithrepository: interscript/interscript+ruby bootstrap.rb(monorepo pattern). Root CI for the monorepo lands in a separate PR.