Skip to content

🐛 Fix same_as_unqualified #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbeno merged 1 commit into from
Jul 6, 2026
Merged

🐛 Fix same_as_unqualified #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions include/stdx/concepts.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ concept derived_from =
std::is_base_of_v<U, T> and
std::is_convertible_v<T const volatile *, U const volatile *>;

namespace detail {
template <typename T, typename U>
concept same_as_helper = std::is_same_v<T, U>;
}

template <typename T, typename U>
concept same_as = std::is_same_v<T, U> and std::is_same_v<U, T>;
concept same_as = detail::same_as_helper<T, U> and detail::same_as_helper<U, T>;

template <typename T, typename... Us>
constexpr auto same_any = (... or same_as<T, Us>);
Expand All @@ -45,8 +50,7 @@ template <typename T, typename... Us>
constexpr auto same_none = not same_any<T, Us...>;

template <typename T, typename U>
concept same_as_unqualified =
is_same_unqualified_v<T, U> and is_same_unqualified_v<U, T>;
concept same_as_unqualified = same_as<remove_cvref_t<T>, remove_cvref_t<U>>;

template <typename T>
concept equality_comparable = requires(T const &t) {
Expand Down Expand Up @@ -133,8 +137,7 @@ template <typename T, template <typename> typename TypeTrait>
concept has_trait = TypeTrait<T>::value;

template <typename T, typename U>
concept same_as_unqualified =
is_same_unqualified_v<T, U> and is_same_unqualified_v<U, T>;
concept same_as_unqualified = same_as<remove_cvref_t<T>, remove_cvref_t<U>>;

template <typename T>
concept structural = is_structural_v<T>;
Expand Down