build(many): remove commonjs build - #2683
Open
joyenjoyer wants to merge 2 commits into
Open
Conversation
Remove the --modules flag and the cjs branch from `ui-scripts build`, along
with specify-commonjs-format.ts (which stamped lib/package.json with
{"type":"commonjs"}). Only the es build remains.
Switch generate-all-tokens to dynamic import() of the es output instead of
require()-ing the lib output.
Ship every InstUI package ESM-only: drop the `lib`/CommonJS build output, `main` field, and `require` export conditions in favor of `type: module` and the existing `es` output. Rename each package's babel.config.js to babel.config.cjs (needed once the package itself is type: module).
Contributor
|
Contributor
Visual regression report
Diff images (33)alert.png — baseline no longer producedavatar.png — baseline no longer producedbadge.png — baseline no longer producedbillboard.png — baseline no longer producedbreadcrumb.png — baseline no longer producedbutton-and-derivatives.png — baseline no longer producedbyline.png — baseline no longer producedcalendar.png — baseline no longer producedcheckbox.png — baseline no longer producedcheckboxgroup.png — baseline no longer producedcolorpicker.png — baseline no longer producedcontextview.png — baseline no longer producedcustom-and-lucide-icons.png — baseline no longer produceddateinput-dateinput2.png — baseline no longer produceddatetimeinput.png — baseline no longer produceddiff-demo.png — 6324 pixels differdrilldown.png — baseline no longer producedfiledrop.png — baseline no longer producedform-errors.png — baseline no longer producedheading.png — baseline no longer producedimg.png — baseline no longer producedlink.png — baseline no longer producedmenu.png — baseline no longer producedmetric-pill-tag-timeselect-text.png — baseline no longer producedoptions.png — baseline no longer producedpagination.png — baseline no longer producedprogressbar.png — baseline no longer producedselect-simpleselect.png — baseline no longer producedtable.png — baseline no longer producedtabs.png — baseline no longer producedtooltip.png — baseline no longer producedtreebrowser.png — baseline no longer producedview.png — baseline no longer producedBaselines come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--modules cjsbuild path fromui-scripts build(babel.ts,specify-commonjs-format.ts) and switchgenerate-all-tokensto import fromes/instead ofrequire()-inglib/@instructure/*package ESM-only: remove thelib/CommonJS output,mainfield, andrequireexport conditions; addtype: module; rename each package'sbabel.config.jstobabel.config.cjsStacked on #2682 (dead babel plugin removal) — base branch will move to
masteronce that merges.Test Plan
pnpm run bootstrap,tsc -b, oxlint, and vitest.Fixes INSTUI-5148
🤖 Generated with Claude Code