chore: replace TypeScript compiler API with jscodeshift in generateVersionedExports - #2676
Merged
joyenjoyer merged 2 commits intoAug 12, 2026
Conversation
…rsionedExports - Rewrite parseVersionedComponents() to use jscodeshift AST parsing - Removes hard dependency on ts.ScriptTarget, ts.isExportDeclaration, etc. - Generates byte-identical output; preparation for TypeScript 7 upgrade - TS 7.0+ changes compiler API surface incompatibly; jscodeshift is stable across versions INSTUI-5144
Contributor
|
Contributor
Visual regression report
Diff images (33)alert.png — baseline no longer producedavatar.png — baseline no longer producedbadge.png — baseline no longer producedbillboard.png — baseline no longer producedbreadcrumb.png — baseline no longer producedbutton-and-derivatives.png — baseline no longer producedbyline.png — baseline no longer producedcalendar.png — baseline no longer producedcheckbox.png — baseline no longer producedcheckboxgroup.png — baseline no longer producedcolorpicker.png — baseline no longer producedcontextview.png — baseline no longer producedcustom-and-lucide-icons.png — baseline no longer produceddateinput-dateinput2.png — baseline no longer produceddatetimeinput.png — baseline no longer produceddiff-demo.png — 6324 pixels differdrilldown.png — baseline no longer producedfiledrop.png — baseline no longer producedform-errors.png — baseline no longer producedheading.png — baseline no longer producedimg.png — baseline no longer producedlink.png — baseline no longer producedmenu.png — baseline no longer producedmetric-pill-tag-timeselect-text.png — baseline no longer producedoptions.png — baseline no longer producedpagination.png — baseline no longer producedprogressbar.png — baseline no longer producedselect-simpleselect.png — baseline no longer producedtable.png — baseline no longer producedtabs.png — baseline no longer producedtooltip.png — baseline no longer producedtreebrowser.png — baseline no longer producedview.png — baseline no longer producedBaselines come from the |
HerrTopi
approved these changes
Aug 7, 2026
HerrTopi
left a comment
HerrTopi
left a comment
Contributor
There was a problem hiding this comment.
Checked the test plan, looks good, but I think I need a bit more context. I'll ask about this later, meanwhile I'll assign the next reviewer
ToMESSKa
requested changes
Aug 7, 2026
| // Extract exported names | ||
| if (node.specifiers && node.specifiers.length > 0) { | ||
| node.specifiers.forEach((spec: any) => { | ||
| if (spec.local && spec.local.name) { |
Contributor
There was a problem hiding this comment.
it('rewrites an import that @instructure/ui re-exports under an alias', () => {
runInlineTest(
updateInstUIImportVersions,
{ versionTo: 'v11.7' },
makeFileInfo(`import { TreeBrowserCollection } from '@instructure/ui'`),
`import { TreeBrowserCollection } from '@instructure/ui/v11_7'`
)
})
If you add this test to packages/ui-codemods/lib/__node_tests__/updateInstUIImportVersions.test.ts, it fails. In packages/ui/src/v11_7.ts, TopNavBarItemChild, TreeBrowserCollection and TreeBrowserCollectionData are aliased. Claude suggests usingspec.exported && spec.exported.name instead of spec.local. Worth checking out.
ToMESSKa
approved these changes
Aug 12, 2026
joyenjoyer
deleted the
INSTUI-5144-swap-ts-6-compiler-api-to-jscodeshift-in-codemods
branch
August 12, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts.ScriptTarget,ts.isExportDeclaration,ts.isNamedExportsTest Plan
node scripts/generateVersionedExports.tsproduces identicalversionedExports.tsoutputpnpm run bootstrapto confirm codemod generation works in the full build pipelineFixes INSTUI-5144
🤖 Generated with Claude Code