Skip to content

fix(ui-checkbox): announce the toggle variant as a toggle button - #2673

Merged
ToMESSKa merged 1 commit into
masterfrom
INSTUI-5023-checkbox-improve-ally-of-toggle-variant
Aug 14, 2026
Merged

fix(ui-checkbox): announce the toggle variant as a toggle button#2673
ToMESSKa merged 1 commit into
masterfrom
INSTUI-5023-checkbox-improve-ally-of-toggle-variant

Conversation

@ToMESSKa

@ToMESSKa ToMESSKa commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

INSTUI-5023

ISSUE:

  • Checkbox toggle variant looks and behaves like a toggle button but announced as checkbox so role and state (checkbox/checked) don't match the presented control (toggle). A suggested fix is adding role=”button” and aria-pressed=”false/true” to the <input>, see https://instructure.atlassian.net/browse/LRN-11564

TEST PLAN:

  • check the Checkbox toggle variant with VoiceOver and NVDA, it should be announced as a "toggle button"

@ToMESSKa ToMESSKa self-assigned this Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-14 10:30 UTC

@ToMESSKa
ToMESSKa requested a review from joyenjoyer July 31, 2026 13:07
@github-actions

Copy link
Copy Markdown
Contributor

Visual regression report

⚠️ Changes detected.

Status Count
Unchanged 0
Changed 1
New 96
Removed 32

📊 View full report

Diff images (33)

alert.png — baseline no longer produced

avatar.png — baseline no longer produced

badge.png — baseline no longer produced

billboard.png — baseline no longer produced

breadcrumb.png — baseline no longer produced

button-and-derivatives.png — baseline no longer produced

byline.png — baseline no longer produced

calendar.png — baseline no longer produced

checkbox.png — baseline no longer produced

checkboxgroup.png — baseline no longer produced

colorpicker.png — baseline no longer produced

contextview.png — baseline no longer produced

custom-and-lucide-icons.png — baseline no longer produced

dateinput-dateinput2.png — baseline no longer produced

datetimeinput.png — baseline no longer produced

diff-demo.png — 6324 pixels differ

drilldown.png — baseline no longer produced

filedrop.png — baseline no longer produced

form-errors.png — baseline no longer produced

heading.png — baseline no longer produced

img.png — baseline no longer produced

link.png — baseline no longer produced

menu.png — baseline no longer produced

metric-pill-tag-timeselect-text.png — baseline no longer produced

options.png — baseline no longer produced

pagination.png — baseline no longer produced

progressbar.png — baseline no longer produced

select-simpleselect.png — baseline no longer produced

table.png — baseline no longer produced

tabs.png — baseline no longer produced

tooltip.png — baseline no longer produced

treebrowser.png — baseline no longer produced

view.png — baseline no longer produced

Baselines come from the visual-baselines branch. They refresh on every merge to master.

github-actions Bot pushed a commit that referenced this pull request Jul 31, 2026

@joyenjoyer joyenjoyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@ToMESSKa
ToMESSKa requested a review from HerrTopi August 11, 2026 07:34
@ToMESSKa
ToMESSKa merged commit c713660 into master Aug 14, 2026
12 of 13 checks passed
@ToMESSKa
ToMESSKa deleted the INSTUI-5023-checkbox-improve-ally-of-toggle-variant branch August 14, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants