Skip to content

fix: lint:changes command to only lint changed files #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyenjoyer wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

fix: lint:changes command to only lint changed files #2665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b15d7
fix: lint:changes command to only lint changed files
joyenjoyer Jul 29, 2026
01cf0ce
fix: skip oxlint invocation in lint:changes when no lintable files ch…
joyenjoyer Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"test:browser-watch": "pnpm run playwright:install && vitest --project browser",
"test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
"lint": "pnpm -r --stream lint",
"lint:changes": "pnpm run lint -- --since HEAD^",
"lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",

@joyenjoyer joyenjoyer Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balzss

  • git diff: list files changed since branching from master
  • grep (+ || true): keep only lintable extensions; don't fail if none match
  • xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

"lint:fix": "pnpm -r --stream lint:fix",
"lint:commits": "commitlint --from=HEAD^1",
"bootstrap": "node scripts/bootstrap.mjs",
Expand Down
Loading