drop Rails < 7.1 conditionals - #46
Merged
maths22 merged 1 commit intoAug 11, 2026
Merged
Conversation
93c38f5 raised the floor to Rails 7.2 but left three Rails.version < "7.1" checks behind, so the older branch of each was no longer reachable.
maths22
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
93c38f5 ("drop ruby < 3.3, Rails < 7.2") raised the gemspec floor to
activerecord/railties>= 7.2, but left threeRails.version < "7.1"checks behind. The older branch of each is unreachable:lib/active_record/pg_extensions/transaction.rb—dirty! unless ::Rails.version < '7.1'spec/spec_helper.rb— pickingexecutevsinternal_executeto patchspec/spec_helper.rb—@connectionvs@raw_connectioninempty_pg_resultNo behavior change on any supported version. 105 examples, 0 failures on Rails 8.1, 8.0, and 7.2;
bin/rubocopclean.Split out of #45 to keep that fix reviewable. The
transaction.rbhunk is adjacent to the one in #45, so this will likely want a trivial rebase once that merges — happy to do that, or to fold this in there instead if you'd rather have one PR.🤖 Generated with Claude Code