Skip to content

97: fix tests for upcoming ggplot2#99

Merged
danielinteractive merged 2 commits into
mainfrom
97_ggplot2_tests_fix
Jul 9, 2025
Merged

97: fix tests for upcoming ggplot2#99
danielinteractive merged 2 commits into
mainfrom
97_ggplot2_tests_fix

Conversation

@danielinteractive

Copy link
Copy Markdown
Collaborator

closes #97

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@danielinteractive

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@danielinteractive danielinteractive requested a review from m7pr June 27, 2025 10:35
@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/geom_km_ticks.R         10       0  100.00%
R/geom_km.R               10       0  100.00%
R/stat_km_compute.R       26       0  100.00%
R/stat_km_ticks.R         10       0  100.00%
R/stat_km.R               10       0  100.00%
TOTAL                     66       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9ede752

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Unit Tests Summary

 1 files  10 suites   2s ⏱️
18 tests 14 ✅ 4 💤 0 ❌
55 runs  48 ✅ 7 💤 0 ❌

Results for commit 9ede752.

♻️ This comment has been updated with latest results.

@danielinteractive

Copy link
Copy Markdown
Collaborator Author

Hi @m7pr , could you please review? I don't have admin rights for this repo so need an approval. Thanks!

@danielinteractive

Copy link
Copy Markdown
Collaborator Author

Hi @pawelru , could you please review and approve? I did not get a response from @m7pr

@danielinteractive danielinteractive requested a review from pawelru July 8, 2025 12:00
Comment thread DESCRIPTION
@danielinteractive danielinteractive merged commit 5ef63d5 into main Jul 9, 2025
29 checks passed
@danielinteractive danielinteractive deleted the 97_ggplot2_tests_fix branch July 9, 2025 08:35
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests break with upcoming ggplot2 version

2 participants